[AMORO-2560]Filformat ORC support roll new file for mixed_format #2561
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #2561 +/- ##
============================================
+ Coverage 32.41% 32.44% +0.02%
Complexity 4407 4407
============================================
Files 590 590
Lines 50041 50041
Branches 6619 6619
============================================
+ Hits 16223 16234 +11
+ Misses 32544 32529 -15
- Partials 1274 1278 +4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
zhoujinsong
approved these changes
Feb 22, 2024
@zhoujinsong Can you cherry-pick this PR to branch 0.6.x? |
Done. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are the changes needed?
Close #2560.
Brief change log
-ORC fileformat support roll new file with self-optimizing.target-size for mixed_format
-Change orc-core.version to 1.8.3
because org.apache.iceberg.orc.OrcFileAppender#length would call org.apache.orc.Writer#estimateMemory, but it did not exsits in orc-core 1.7.2, which would cause java.lang.NoSuchMethodError: org.apache.orc.Writer.estimateMemory as below
How was this patch tested?
Add some test cases that check the changes thoroughly including negative and positive cases if possible
Add screenshots for manual tests if appropriate
Run test locally before making a pull request
Documentation