Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Doc]Fix typo in managing-optimizers.md #3059

Merged
merged 1 commit into from
Jul 23, 2024

Conversation

xieyi888
Copy link
Contributor

Why are the changes needed?

Fix typo in managing-optimizers.md

Brief change log

How was this patch tested?

  • Add some test cases that check the changes thoroughly including negative and positive cases if possible

  • Add screenshots for manual tests if appropriate

  • Run test locally before making a pull request

Documentation

  • Does this pull request introduce a new feature? (yes / no)
  • If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)

@github-actions github-actions bot added the type:docs Improvements or additions to documentation label Jul 23, 2024
@huyuanfeng2018
Copy link
Contributor

@xieyi888
Thank you very much for your contribution, can you submit this PR to this project?
https://github.com/apache/amoro-site/blob/master/amoro-docs/content/admin-guides/managing-optimizers.md

Copy link
Contributor

@tcodehuber tcodehuber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@huyuanfeng2018
Copy link
Contributor

@xieyi888
Thank you very much for your contribution, can you submit this PR to this project?
https://github.com/apache/amoro-site/blob/master/amoro-docs/content/admin-guides/managing-optimizers.md

I was wrong. doc will synchronize the website

Copy link
Contributor

@huyuanfeng2018 huyuanfeng2018 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@XBaith XBaith merged commit fafb3f4 into apache:master Jul 23, 2024
1 check passed
@klion26 klion26 mentioned this pull request Aug 21, 2024
28 tasks
zhoujinsong pushed a commit that referenced this pull request Oct 11, 2024
fix typo in managing-optimizers.md

(cherry picked from commit fafb3f4)
Signed-off-by: zhoujinsong <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:docs Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants