Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Hotfix] Fix the function that convert ms #3069

Merged
merged 1 commit into from
Aug 7, 2024

Conversation

chouchouji
Copy link
Contributor

@chouchouji chouchouji commented Jul 29, 2024

image

Why are the changes needed?

Close #xxx.

Brief change log

How was this patch tested?

  • Add some test cases that check the changes thoroughly including negative and positive cases if possible

  • Add screenshots for manual tests if appropriate

  • Run test locally before making a pull request

Documentation

  • Does this pull request introduce a new feature? (yes / no)
  • If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)

@github-actions github-actions bot added the module:ams-dashboard Ams dashboard module label Jul 29, 2024
@chouchouji chouchouji force-pushed the fix-format-ms-function branch from d7366c3 to fd53b1a Compare July 29, 2024 13:54
@chouchouji chouchouji changed the title [Hotfix] refactor the function that format ms [Hotfix] Fix the function that convert ms Jul 29, 2024
Copy link
Member

@zhangmo8 zhangmo8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@tcodehuber tcodehuber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zhoujinsong zhoujinsong merged commit a550103 into apache:master Aug 7, 2024
4 checks passed
@zhoujinsong
Copy link
Contributor

Thanks for the contribution! @chouchouji
Thanks for the review! @zhangmo8 @tcodehuber

@klion26 klion26 mentioned this pull request Aug 21, 2024
28 tasks
@chouchouji chouchouji deleted the fix-format-ms-function branch August 29, 2024 09:16
zhoujinsong pushed a commit that referenced this pull request Oct 11, 2024
(cherry picked from commit a550103)
Signed-off-by: zhoujinsong <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
module:ams-dashboard Ams dashboard module
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants