[AMORO-2204] Support Spark 3.5 for mixed format tables #3428
+45,012
−58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
module:mixed-spark
github-actions
bot
removed
module:ams-optimizer
Aireed
reviewed
Mar 12, 2025
| protected TableIdentifier generateChangeStoreIdentifier(TableIdentifier baseIdentifier) { | ||
| return TableIdentifier.of( | ||
| baseIdentifier.namespace(), | ||
| baseIdentifier.name() + CHANGE_STORE_SEPARATOR + MixedTable.CHANGE_STORE_IDENTIFIER); |
There was a problem hiding this comment.
should we replace CHANGE_STORE_SEPARATOR to this.separtor
Suggested change
| baseIdentifier.name() + CHANGE_STORE_SEPARATOR + MixedTable.CHANGE_STORE_IDENTIFIER); | |
| baseIdentifier.name() + CHANGE_STORE_SEPARATOR + MixedTable.CHANGE_STORE_IDENTIFIER); |
| @@ -43,7 +44,6 @@ | |||
| public class InternalMixedIcebergCatalog extends BasicMixedIcebergCatalog { | |||
|
|
|||
| public static final String CHANGE_STORE_SEPARATOR = "@"; | |||
There was a problem hiding this comment.
@ is not validate for table name in hive
Suggested change
| public static final String CHANGE_STORE_SEPARATOR = "@"; | |
| public static final String CHANGE_STORE_SEPARATOR = "@"; |
| properties.remove(TableCatalog.PROP_LOCATION); | ||
| } | ||
| try { | ||
| if (properties.containsKey("primary.keys")) { |
There was a problem hiding this comment.
should we add a definition in TableProperties.class for "primary.keys" ?
| // one order leads to different results | ||
| Preconditions.checkArgument( | ||
| setSnapshotId == null || pickSnapshotId == null, | ||
| "Cannot set the current the current snapshot ID and cherry-pick snapshot changes"); |
There was a problem hiding this comment.
Suggested change
| "Cannot set the current the current snapshot ID and cherry-pick snapshot changes"); | |
| "Cannot set the current snapshot ID and cherry-pick snapshot changes at the same time"); | |
| Map<String, String> properties = Maps.newHashMap(); | ||
| properties.putAll(sourceTable.properties()); | ||
| EXCLUDED_PROPERTIES.forEach(properties::remove); | ||
| properties.put(TableCatalog.PROP_PROVIDER, "arctic"); |
There was a problem hiding this comment.
Suggested change
| properties.put(TableCatalog.PROP_PROVIDER, "arctic"); | |
| properties.put(TableCatalog.PROP_PROVIDER, "mixed_hive"); |
| properties.putAll(sourceTable.properties()); | ||
| EXCLUDED_PROPERTIES.forEach(properties::remove); | ||
| properties.put(TableCatalog.PROP_PROVIDER, "arctic"); | ||
| properties.put("migrated", "true"); |
There was a problem hiding this comment.
Add a prefix to indicate that this parameter is used by amoro.
Suggested change
| properties.put("migrated", "true"); | |
| properties.put("amoro.migrated", "true"); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are the changes needed?
Close #2204.
Brief change log
How was this patch tested?
Add some test cases that check the changes thoroughly including negative and positive cases if possible
Add screenshots for manual tests if appropriate
Run test locally before making a pull request
Documentation