[AMORO-3451] Fix kubernetes optimizer pod is frequently being killed #3458
+21
−11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I didn't format the code😂, I'll pay attention next time. |
czy006
reviewed
Mar 6, 2025
|
|
||
| if (resource.getMemoryMb() > 0) { | ||
| memory = resource.getMemoryMb(); | ||
| } else { | ||
| memoryPerThread = Long.parseLong(checkAndGetProperty(groupProperties, MEMORY_PROPERTY)); | ||
| memory = memoryPerThread * resource.getThreadCount(); | ||
| } | ||
|
|
||
| // reserving 20% of total pod memory for JVM non-heap memory | ||
| jvmHeapMemory = (long) (memory * 0.8); |
There was a problem hiding this comment.
If we do not use off-heap memory in the code, I think it can be set to 0.9, which will not cause the container to be killed. If it is still frequently killed by OOM, we may need to check whether there is a memory leak in the code or the instantaneous Heap usage exceeds the container limit. We may be able to provide an external parameter for users to set, WDYT?
There was a problem hiding this comment.
Sounds great, I'll work on it.
Marvel-Gu
force-pushed
the
fix-k8s-optimizer-jvmHeapMemery-size
branch
from
7bfe3c3 to
c5c3e8e
Compare
|
The default 80% configuration looks good to me. Maybe we can merge this PR now or do we have some other thing to validate before that? @Marvel-Gu @czy006 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are the changes needed?
Close #3451.
Brief change log
In ams KubernetesOptimizerContainer, limit the size of the JVM heap memory to 80% of the pod's memory limit.
How was this patch tested?
Add some test cases that check the changes thoroughly including negative and positive cases if possible
Add screenshots for manual tests if appropriate
Run test locally before making a pull request
Documentation