[ARCTIC-260][Core]Support loading Iceberg catalog #549
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hzluting
reviewed
Nov 1, 2022
core/src/main/java/com/netease/arctic/catalog/CatalogLoader.java
Outdated
Show resolved
Hide resolved
hzluting
approved these changes
Nov 1, 2022
baiyangtx
reviewed
Nov 1, 2022
core/src/main/java/com/netease/arctic/catalog/CatalogLoader.java
Outdated
Show resolved
Hide resolved
| String catalogImpl; | ||
| Set<TableFormat> tableFormats = CatalogUtil.tableFormats(catalogMeta); | ||
| Preconditions.checkArgument(tableFormats.size() == 1, "Catalog support only one table format now."); | ||
| TableFormat tableFormat = tableFormats.iterator().next(); | ||
| switch (type) { |
There was a problem hiding this comment.
这边在实现上，是不是不要在代码层面复用 type 字段了。 v0.4 就直接引入 metastore, table-format 两个新字段。 v0.3 的还走 type 逻辑。 这样代码上更清晰一些。
在兼容性上，保证 v0.4 接口还有 type 字段，v0.5 开始就不返回 type 字段了？
There was a problem hiding this comment.
catalog type is the same with metastore in AMS Dashboard.
I prefer to not add a metastore property in database and thrift argument.
baiyangtx
approved these changes
Nov 1, 2022
Aireed
reviewed
Nov 1, 2022
| return tableMetaStore.doAs(() -> ((SupportsNamespaces)icebergCatalog).listNamespaces(Namespace.empty()).stream() | ||
| .map(namespace -> namespace.level(0)).distinct().collect(Collectors.toList())); | ||
| } else { | ||
| throw new UnsupportedOperationException(String.format("Iceberg catalog: %s do now implement SupportsNamespaces", |
There was a problem hiding this comment.
throw new UnsupportedOperationException(String.format("Iceberg catalog: %s do now implement SupportsNamespaces",
'do now' should be does not ?
| return null; | ||
| }); | ||
| } else { | ||
| throw new UnsupportedOperationException(String.format("Iceberg catalog: %s do now implement SupportsNamespaces", |
| return null; | ||
| }); | ||
| } else { | ||
| throw new UnsupportedOperationException(String.format("Iceberg catalog: %s do now implement SupportsNamespaces", |
There was a problem hiding this comment.
throw new UnsupportedOperationException(String.format("Iceberg catalog: %s do now implement SupportsNamespaces",
'do now' should be does not ?
wangtaohz
pushed a commit
to wangtaohz/amoro
that referenced
this pull request
Nov 7, 2022
* add BaseIcebergCatalog * fix compile errors * fix style errors * fix comments
zhoujinsong
added a commit
that referenced
this pull request
May 31, 2023
* add BaseIcebergCatalog * fix compile errors * fix style errors * fix comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are the changes needed?
Subtask of #260.
Support loading iceberg catalog.
Brief change log
How was this patch tested?
Add some test cases that check the changes thoroughly including negative and positive cases if possible
Add screenshots for manual tests if appropriate
Run test locally before making a pull request
Documentation