Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: clean up markdown syntax for docusaurus 3 #17740

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

317brian
Copy link
Contributor

@317brian 317brian commented Feb 19, 2025

Used the docusaurus syntax checker to clean up the errors so that the site will comply with MDX v3

npx docusaurus-mdx-checker

This update to the build/copy script in druid-website-src needs to be reviewed and merged to accomdodate the escaped DRUIDVERSION variable: apache/druid-website-src#519

The best way to review this is concurrently with 519. Run the do all things script in 519 and verify the prod output with yarn/npm run serve

This PR has:

  • been self-reviewed.

(cherry picked from commit 91ec717)
(cherry picked from commit 854dccb)
(cherry picked from commit 27dfa07)
@317brian 317brian marked this pull request as ready for review February 20, 2025 21:25
@@ -101,7 +101,7 @@ All of these community extensions can be downloaded using [pull-deps](../operati
|druid-momentsketch|Support for approximate quantile queries using the [momentsketch](https://github.com/stanford-futuredata/momentsketch) library|[link](../development/extensions-contrib/momentsketch-quantiles.md)|
|druid-tdigestsketch|Support for approximate sketch aggregators based on [T-Digest](https://github.com/tdunning/t-digest)|[link](../development/extensions-contrib/tdigestsketch-quantiles.md)|
|gce-extensions|GCE Extensions|[link](../development/extensions-contrib/gce-extensions.md)|
|prometheus-emitter|Exposes [Druid metrics](../operations/metrics.md) for Prometheus server collection (<https://prometheus.io/>)|[link](../development/extensions-contrib/prometheus.md)|
|prometheus-emitter|Exposes [Druid metrics](../operations/metrics.md) for Prometheus server collection (https://prometheus.io/)|[link](../development/extensions-contrib/prometheus.md)|
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
|prometheus-emitter|Exposes [Druid metrics](../operations/metrics.md) for Prometheus server collection (https://prometheus.io/)|[link](../development/extensions-contrib/prometheus.md)|
|prometheus-emitter|Exposes [Druid metrics](../operations/metrics.md) for [Prometheus](https://prometheus.io/) server collection |[link](../development/extensions-contrib/prometheus.md)|

@@ -68,7 +68,7 @@ A tableSpec defines a table
|--------------|---------------------|------------------------------------------------------------------------------------------------------------------------|----------|---------|
| `name` | String | The name of the column | yes | null |
| `dataType` | String | The type of the column. Can be any column data type that is available to Druid. Depends on what extensions are loaded. | no | null |
| `properties` | Map<String, Object> | the column's defined properties. Non properties defined at this time. | no | null |
| `properties` | Map&lt;String, Object\> | the column's defined properties. Non properties defined at this time. | no | null |
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If the > needs a backslash, do you also need to for lines 55-56?

@@ -399,7 +399,7 @@ For details, see the Schema Registry [documentation](http://docs.confluent.io/cu
| type | String | Set value to `schema_registry`. | no |
| url | String | Specifies the URL endpoint of the Schema Registry. | yes |
| capacity | Integer | Specifies the max size of the cache (default = Integer.MAX_VALUE). | no |
| urls | Array<String\> | Specifies the URL endpoints of the multiple Schema Registry instances. | yes (if `url` is not provided) |
| urls | Array\<String\> | Specifies the URL endpoints of the multiple Schema Registry instances. | yes (if `url` is not provided) |
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

undo this change? the first \ shows up

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also applies to other instances throughout

@@ -43,7 +43,7 @@ This expression language supports the following operators (listed in decreasing
|^|Binary power op|
|*, /, %|Binary multiplicative|
|+, -|Binary additive|
|<, <=, >, >=, ==, !=|Binary Comparison|
|&lt;, &le;, &gt;, &ge;, ==, &ne;|Binary Comparison|
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The != shows up as , not sure if that's intentional

@@ -330,7 +330,7 @@ FROM (
PARTITIONED BY ALL
```

## Ingest a JSON string as COMPLEX<json\>
## Ingest a JSON string as COMPLEX\<json\>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also here

@@ -24,15 +24,15 @@ title: "Release notes"

<!--Replace {{DRUIDVERSION}} with the correct Druid version.-->

Apache Druid {{DRUIDVERSION}} contains over $NUMBER_FEATURES new features, bug fixes, performance enhancements, documentation improvements, and additional test coverage from $NUMBER_OF_CONTRIBUTORS contributors.
Apache Druid \{\{DRUIDVERSION}} contains over $NUMBER_FEATURES new features, bug fixes, performance enhancements, documentation improvements, and additional test coverage from $NUMBER_OF_CONTRIBUTORS contributors.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is showing up as Apache Druid {\32.0.0} contains

@@ -148,7 +148,7 @@ From the Hadoop container's shell, run the following command to copy the Hadoop
cp /usr/local/hadoop/etc/hadoop/*.xml /shared/hadoop_xml
```

From the host machine, run the following, where {PATH_TO_DRUID} is replaced by the path to the Druid package.
From the host machine, run the following, where \{PATH_TO_DRUID\} is replaced by the path to the Druid package.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this get interpreted at build or later? I see

From the host machine, run the following, where {PATH_TO_DRUID} is replaced by the path to the Druid package.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants