Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug report] In the Web UI if a catalog has no schemas API calls are made with null in them #1001

Closed
justinmclean opened this issue Dec 7, 2023 · 1 comment · Fixed by #1365
Assignees

Comments

@justinmclean
Copy link
Member

Describe what's wrong

The web UI tried to make these calls which fail:
http://localhost:3000/api/metalakes/metalake/catalogs/null
http://localhost:3000/api/metalakes/metalake/catalogs/null/schemas

There errors are hidden and only show up in teh developer console.

(Note also that null coudl be a valid but poor choice of a name for a schema)

Error message and/or stacktrace

 {message: 'Request failed with status code 404', name: 'AxiosError', code: 'ERR_BAD_REQUEST', config: {…}, request: XMLHttpRequest, …}
 M {message: 'Request failed with status code 404', name: 'AxiosError', code: 'ERR_BAD_REQUEST', config: {…}, request: XMLHttpRequest, …}

How to reproduce

Create a metalake and a catalog:
curl -X POST -H "Content-Type: application/json" -d '{"name":"metalake","comment":"Test metalake"}' http://localhost:8090/api/metalakes
curl -X POST -H "Content-Type: application/json" -d '{"name":"test","comment":"Test catalog","type":"RELATIONAL", "provider":"hive","properties":{"metastore.uris":"thrift://0.0.0.0:9083"}}' http://localhost:8090/api/metalakes/metalake/catalogs

View the catalog in the UI.

Additional context

No response

@jerryshao jerryshao added this to the Gravitino 0.3.0 milestone Dec 7, 2023
@ch3yne
Copy link
Contributor

ch3yne commented Dec 8, 2023

I will fix it later.

jerryshao pushed a commit that referenced this issue Jan 8, 2024
### What changes were proposed in this pull request?

Rectify the issue of null being included in the requests.

### Why are the changes needed?

Fix: #1001

### Does this PR introduce _any_ user-facing change?

N/A

### How was this patch tested?

N/A
github-actions bot pushed a commit that referenced this issue Jan 8, 2024
### What changes were proposed in this pull request?

Rectify the issue of null being included in the requests.

### Why are the changes needed?

Fix: #1001

### Does this PR introduce _any_ user-facing change?

N/A

### How was this patch tested?

N/A
qqqttt123 pushed a commit that referenced this issue Jan 8, 2024
### What changes were proposed in this pull request?

Rectify the issue of null being included in the requests.

### Why are the changes needed?

Fix: #1001

### Does this PR introduce _any_ user-facing change?

N/A

### How was this patch tested?

N/A

Co-authored-by: CHEYNE <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants