Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug report] Unnecessary fields submitted when create a catalog in the web UI #1403

Closed
ch3yne opened this issue Jan 9, 2024 · 0 comments · Fixed by #1404
Closed

[Bug report] Unnecessary fields submitted when create a catalog in the web UI #1403

ch3yne opened this issue Jan 9, 2024 · 0 comments · Fixed by #1404
Assignees
@ch3yne

Comments

@ch3yne
Copy link
Contributor

ch3yne commented Jan 9, 2024

Describe what's wrong

When creating a catalog and the provider is iceberg and the catalog-backend is hive, submitted the unnecessary fields.

Error message and/or stacktrace

hive

How to reproduce

  1. click create catalog button
  2. set the properties with the provider is iceberg and the catalog-backend is hive
  3. click submit

Additional context

No response
@ch3yne ch3yne self-assigned this Jan 9, 2024
@ch3yne ch3yne mentioned this issue Jan 9, 2024
Merged
jerryshao pushed a commit that referenced this issue Jan 9, 2024
@ch3yne
[#1403] fix(UI): Remove unnecessary fields when creating a catalog in…
1370327 
… the web UI (#1404)

### What changes were proposed in this pull request?

Fix submitted the unnecessary fields when create a catalog.

if `provider` is `iceberg`, and `catalog-backend` is `hive`, the
properties payload should not includes `jdbc-*`

1. request payload
<img width="270" alt="image"
src="https://github.com/datastrato/gravitino/assets/17310559/6b7a2947-0be9-49eb-8972-a302eea31d7f">

2. response data
<img width="269" alt="image"
src="https://github.com/datastrato/gravitino/assets/17310559/c2b2880e-fd4e-417e-9fe9-e3dc41beef0a">


### Why are the changes needed?

Fix: #1403

### Does this PR introduce _any_ user-facing change?

N/A

### How was this patch tested?

N/A
github-actions bot pushed a commit that referenced this issue Jan 9, 2024
@ch3yne @web-flow
[#1403] fix(UI): Remove unnecessary fields when creating a catalog in…
ed9acdf 
… the web UI (#1404)

### What changes were proposed in this pull request?

Fix submitted the unnecessary fields when create a catalog.

if `provider` is `iceberg`, and `catalog-backend` is `hive`, the
properties payload should not includes `jdbc-*`

1. request payload
<img width="270" alt="image"
src="https://github.com/datastrato/gravitino/assets/17310559/6b7a2947-0be9-49eb-8972-a302eea31d7f">

2. response data
<img width="269" alt="image"
src="https://github.com/datastrato/gravitino/assets/17310559/c2b2880e-fd4e-417e-9fe9-e3dc41beef0a">


### Why are the changes needed?

Fix: #1403

### Does this PR introduce _any_ user-facing change?

N/A

### How was this patch tested?

N/A
@jerryshao jerryshao mentioned this issue Jan 9, 2024
Merged
yuqi1129 pushed a commit that referenced this issue Jan 9, 2024
@jerryshao @ch3yne
[#1403] fix(UI): Remove unnecessary fields when creating a catalog in…
13ff4c9 
… the web UI (#1407)

### What changes were proposed in this pull request?

Fix submitted the unnecessary fields when create a catalog.

if `provider` is `iceberg`, and `catalog-backend` is `hive`, the
properties payload should not includes `jdbc-*`

1. request payload
<img width="270" alt="image"
src="https://github.com/datastrato/gravitino/assets/17310559/6b7a2947-0be9-49eb-8972-a302eea31d7f">

2. response data
<img width="269" alt="image"
src="https://github.com/datastrato/gravitino/assets/17310559/c2b2880e-fd4e-417e-9fe9-e3dc41beef0a">


### Why are the changes needed?

Fix: #1403

### Does this PR introduce _any_ user-facing change?

N/A

### How was this patch tested?

N/A

Co-authored-by: CHEYNE <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ch3yne ch3yne

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[#1403] fix(UI): Remove unnecessary fields when creating a catalog in the web UI ch3yne/gravitino
1 participant
@ch3yne