Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEATURE] Support GCS for python GVFS client #5139

Closed
yuqi1129 opened this issue Oct 15, 2024 · 0 comments · Fixed by #5160
Closed

[FEATURE] Support GCS for python GVFS client #5139

yuqi1129 opened this issue Oct 15, 2024 · 0 comments · Fixed by #5160
Assignees
@yuqi1129
Labels
0.7.0 Release v0.7.0 improvement Improvements on everything

Comments

@yuqi1129
Copy link
Contributor

What would you like to be improved?

As the PRs #5079 and #4232 are undergoing, we also need to change the python gvfs client to support GCS and S3

How should we improve?

No response
@yuqi1129 yuqi1129 added the improvement Improvements on everything label Oct 15, 2024
@yuqi1129 yuqi1129 changed the title [Improvement] Support GCS and S3 for python GVFS client [FEATURE] Support GCS and S3 for python GVFS client Oct 15, 2024
@yuqi1129 yuqi1129 self-assigned this Oct 15, 2024
@yuqi1129 yuqi1129 mentioned this issue Oct 16, 2024
Merged
@yuqi1129 yuqi1129 changed the title [FEATURE] Support GCS and S3 for python GVFS client [FEATURE] Support GCS for python GVFS client Oct 21, 2024
jerryshao pushed a commit that referenced this issue Oct 21, 2024
@yuqi1129
[#5139] feat(python-client): Support GCS fileset in the python GVFS c…
ef44021 
…lient (#5160)

### What changes were proposed in this pull request?

- Support GCS fileset in the Python GVFS client
- Add an IT about the GCS fileset.

### Why are the changes needed?

It's user needs.

Fix: #5139

### Does this PR introduce _any_ user-facing change?

Modify the Python GVFS client. 

### How was this patch tested?

Test locally and add an IT that can't run automatically. 

Modify mode as the following picture and execute `./gradlew
:clients:client-python:test -PskipDockerTests=false` success.

<img width="1332" alt="image"
src="https://github.com/user-attachments/assets/e3b781fa-3ac1-458a-9224-d7e01107828b">


<img width="1530" alt="image"
src="https://github.com/user-attachments/assets/f53c2d20-c253-4eb9-a84f-4c13569b513b">
@jerryshao jerryshao added the 0.7.0 Release v0.7.0 label Oct 21, 2024
mplmoknijb pushed a commit to mplmoknijb/gravitino that referenced this issue Nov 6, 2024
@yuqi1129 @mplmoknijb
[apache#5139] feat(python-client): Support GCS fileset in the python …
015e808 
…GVFS client (apache#5160)

### What changes were proposed in this pull request?

- Support GCS fileset in the Python GVFS client
- Add an IT about the GCS fileset.

### Why are the changes needed?

It's user needs.

Fix: apache#5139

### Does this PR introduce _any_ user-facing change?

Modify the Python GVFS client. 

### How was this patch tested?

Test locally and add an IT that can't run automatically. 

Modify mode as the following picture and execute `./gradlew
:clients:client-python:test -PskipDockerTests=false` success.

<img width="1332" alt="image"
src="https://github.com/user-attachments/assets/e3b781fa-3ac1-458a-9224-d7e01107828b">


<img width="1530" alt="image"
src="https://github.com/user-attachments/assets/f53c2d20-c253-4eb9-a84f-4c13569b513b">
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@yuqi1129 yuqi1129

Labels
0.7.0 Release v0.7.0 improvement Improvements on everything
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[#5139] feat(python-client): Support GCS fileset in the python GVFS client yuqi1129/gravitino
2 participants
@jerryshao @yuqi1129