[MINOR] refactor: Tweak the build script #6677
Conversation
|
@tengqm There're some build issues about the change, can you please check the CI log and fix it. |
OK. |
tengqm
force-pushed
the
fix-build-script
branch
3 times, most recently
from
2b65d42 to
eab465d
Compare
| "--add-opens", "java.base/sun.nio.ch=ALL-UNNAMED", | ||
| "--add-opens", "java.base/sun.nio.cs=ALL-UNNAMED", | ||
| "--add-opens", "java.base/sun.security.action=ALL-UNNAMED", | ||
| "--add-opens", "java.base/sun.util.calendar=ALL-UNNAMED", | ||
| "--add-opens", "java.security.jgss/sun.security.krb5=ALL-UNNAMED", | ||
| "--add-opens", "java.base/java.lang.reflect=ALL-UNNAMED" |
There was a problem hiding this comment.
To reviwers: This entry was found to be duplicated after sorting the list.
| "--add-opens", "java.base/jdk.internal.ref=ALL-UNNAMED", | ||
| "--add-opens", "java.base/jdk.internal.reflect=ALL-UNNAMED", | ||
| "--add-opens", "java.sql/java.sql=ALL-UNNAMED", | ||
| "--add-opens", "java.base/sun.util.calendar=ALL-UNNAMED", |
There was a problem hiding this comment.
To reviwers: This entry was found to be duplicated after sorting the list.
| "web/web/src/lib/icons/svg/**/*.svg", | ||
| "web/web/src/lib/utils/axios/**/*", | ||
| "web/web/src/types/axios.d.ts", | ||
| "web/web/yarn.lock" |
There was a problem hiding this comment.
To reviwers: contents not changed other than sorting the entries
| "copySubprojectDependencies", | ||
| "copySubprojectLib", | ||
| ":authorizations:copyLibAndConfig", | ||
| ":iceberg:iceberg-rest-server:copyLibAndConfigs", |
There was a problem hiding this comment.
To reviwers: by wrapping the long line, the missing leading ':' for iceberg one becomes obvious.
| it.parent?.name != "bundles" && it.name != "hadoop-common" | ||
| !it.name.startsWith("client") && | ||
| !it.name.startsWith("filesystem") && | ||
| !it.name.startsWith("flink") && |
There was a problem hiding this comment.
To reviwers: by wrapping the long line, we found that 'flink' is duplicated.
| it.name != "bundled-catalog" && | ||
| it.name != "hadoop-common" && | ||
| it.name != "hive-metastore-common" && | ||
| it.name != "integration-test" && |
There was a problem hiding this comment.
To reviwers: by wrapping the long line and sorting the entries, duplication of 'integration-test' is obvious.
| ":catalogs:catalog-kafka:copyLibAndConfig", | ||
| ":catalogs:catalog-lakehouse-hudi:copyLibAndConfig", |
There was a problem hiding this comment.
To reviewers: 'catalogs:catalog-lakehouse-hudi:copyLibAndConfig' was missing the leading ':'.
There was a problem hiding this comment.
�It's fine, these two ways are both workable for Gradle.
tengqm
force-pushed
the
fix-build-script
branch
from
eab465d to
b87b73c
Compare
|
@yuqi1129 can you please help to review this PR? |
| "--add-opens", "java.base/jdk.internal.ref=ALL-UNNAMED", | ||
| "--add-opens", "java.base/jdk.internal.reflect=ALL-UNNAMED", | ||
| "--add-opens", "java.sql/java.sql=ALL-UNNAMED", | ||
| "--add-opens", "java.base/sun.util.calendar=ALL-UNNAMED", |
tengqm
force-pushed
the
fix-build-script
branch
from
b87b73c to
4abc291
Compare
What changes were proposed in this pull request?
This PR tweaks the build script for coding style consistency.
It also fixes a few nits in the scripts:
Why are the changes needed?
See description.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
N/A