Fix compile failures

[fqaiser94]

Fixes: #104

I think something was merged in after #94 without rebasing on top of main resulting in some compile failures (type check errors).

Not a big deal, easily fixed.

[liurenjie1024]

LGTM, Thanks!

[liurenjie1024]

It seems that ci settings ci didn't enforce rebase before merging. Not sure if this the limitation of apache infra.

[Fokko]

@liurenjie1024

It seems that ci settings ci didn't enforce rebase before merging. Not sure if this the limitation of apache infra.

This can be configured in the .asf.yaml on a per-branch basis:

github:
  protected_branches:
    main:
      required_status_checks:
        # strict means "Require branches to be up to date before merging".
        strict: true

See https://cwiki.apache.org/confluence/pages/viewpage.action?spaceKey=INFRA&title=Git+-+.asf.yaml+features

[Fokko]

Thanks for fixing this @fqaiser94 and @liurenjie1024 for the review 🙌

[liurenjie1024]

@liurenjie1024

It seems that ci settings ci didn't enforce rebase before merging. Not sure if this the limitation of apache infra.

This can be configured in the .asf.yaml on a per-branch basis:

github:

  protected_branches:

    main:

      required_status_checks:

        # strict means "Require branches to be up to date before merging".

        strict: true

See https://cwiki.apache.org/confluence/pages/viewpage.action?spaceKey=INFRA&title=Git+-+.asf.yaml+features

I've already enabled this but It seems Not working.