feat: Add conversion from FileMetaData to ParquetMetadata
#1074
+61
−89
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
liurenjie1024
approved these changes
Mar 13, 2025
There was a problem hiding this comment.
Thanks @jonathanc-n , LGTM! Just a minor concern about thrift depdenency, let's wait for @Xuanwo to take a look.
Xuanwo
reviewed
Mar 13, 2025
| min_max_agg.produce(), | ||
| ) | ||
| }; | ||
| let parquet_metadata = ParquetMetaDataReader::decode_metadata(&buffer).unwrap(); |
There was a problem hiding this comment.
How about returning an error instead?
| let metadata = writer.close().await.map_err(|err| { | ||
| Error::new(ErrorKind::Unexpected, "Failed to close parquet writer.").with_source(err) | ||
| })?; | ||
|
|
||
| let written_size = self.written_size.load(std::sync::atomic::Ordering::Relaxed); | ||
|
|
||
| Ok(vec
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
What changes are included in this PR?
Add conversion from filemetadat to parquet metadata using thrift
decode_metadataAre these changes tested?