feat: add apply in transaction to support stack action #949
+145
−93
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ZENOTME
force-pushed
the
apply_metadata
branch
from
c20c598 to
536dce7
Compare
|
Hi @liurenjie1024, I think we should resolve this PR first before working on #964. It will affect the interface in transactions. |
ZENOTME
force-pushed
the
apply_metadata
branch
4 times, most recently
from
5e8e0b0 to
9b7ef77
Compare
|
I think this PR is ready to review. cc @Fokko @liurenjie1024 @Xuanwo @sdd |
ZENOTME
commented
Mar 12, 2025
| @@ -261,7 +286,7 @@ impl<'a> FastAppendAction<'a> { | |||
| let mut manifest_stream = self | |||
| .snapshot_produce_action | |||
| .tx | |||
| .table | |||
| .current_table | |||
There was a problem hiding this comment.
I realized that there are some functions based on the table. And storing only current metadata may cause inconsistencies easily in the future. So change to store current table instead of metadata
jonathanc-n
approved these changes
Mar 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR resolve: #596. I refer the implementation from pyiceberg: https://github.com/apache/iceberg-python/blob/4d648bb834963efba886d62e79fa3e1e26288dd0/pyiceberg/table/__init__.py#L258