Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PARQUET-2499: Update NOTICE to Apache Parquet Java #1375

Merged
merged 3 commits into from
Jun 20, 2024
Merged

PARQUET-2499: Update NOTICE to Apache Parquet Java #1375

merged 3 commits into from
Jun 20, 2024

Conversation

caicancai
Copy link
Member

@caicancai caicancai commented Jun 16, 2024

Make sure you have checked all steps below.

Jira

Tests

  • My PR adds the following unit tests OR does not need testing for this extremely good reason:

Commits

  • My commits all reference Jira issues in their subject lines. In addition, my commits follow the guidelines
    from "How to write a good git commit message":
    1. Subject is separated from body by a blank line
    2. Subject is limited to 50 characters (not including Jira issue reference)
    3. Subject does not end with a period
    4. Subject uses the imperative mood ("add", not "adding")
    5. Body wraps at 72 characters
    6. Body explains "what" and "why", not "how"

Style

  • My contribution adheres to the code style guidelines and Spotless passes.
    • To apply the necessary changes, run mvn spotless:apply -Pvector-plugins

Documentation

  • In case of new functionality, my PR adds documentation that describes how to use it.
    • All the public functions and the classes in the PR contain Javadoc that explain what it does

@caicancai
Copy link
Member Author

cc @wgtmac @Fokko

@wgtmac
Copy link
Member

wgtmac commented Jun 17, 2024

Thanks for the contribution! Could you help fix other similar places as well?

@caicancai
Copy link
Member Author

caicancai commented Jun 17, 2024

Thanks for the contribution! Could you help fix other similar places as well?

Fix

@caicancai
Copy link
Member Author

@Fokko @wgtmac Thank you for your review

@wgtmac
Copy link
Member

wgtmac commented Jun 19, 2024

Could you help fix

<name>Apache Parquet MR</name>
as well?

@wgtmac wgtmac changed the title [PARQUET-2499] Update NOTICE to Apache Parquet Java PARQUET-2499: Update NOTICE to Apache Parquet Java Jun 20, 2024
@wgtmac wgtmac merged commit 8fb5421 into apache:master Jun 20, 2024
9 checks passed
@caicancai caicancai deleted the 2499 branch June 20, 2024 06:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants