Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Query Resource Isolation] Workload Configs #15109

Draft
wants to merge 9 commits into
base: master
Choose a base branch
from

Conversation

praveenc7
Copy link
Contributor

@praveenc7 praveenc7 commented Feb 21, 2025

Add Workload Configs to be used for query resource isolation

@codecov-commenter
Copy link

codecov-commenter commented Feb 21, 2025

Codecov Report

Attention: Patch coverage is 44.59459% with 82 lines in your changes missing coverage. Please review.

Project coverage is 56.16%. Comparing base (59551e4) to head (517abdd).
Report is 1837 commits behind head on master.

Files with missing lines Patch % Lines
...ache/pinot/common/metadata/ZKMetadataProvider.java 0.00% 27 Missing ⚠️
...t/common/messages/QueryWorkloadRefreshMessage.java 0.00% 15 Missing ⚠️
...apache/pinot/spi/config/workload/InstanceCost.java 0.00% 14 Missing ⚠️
...g/apache/pinot/spi/config/workload/NodeConfig.java 66.66% 6 Missing and 2 partials ⚠️
...e/pinot/spi/config/workload/PropagationScheme.java 66.66% 6 Missing and 2 partials ⚠️
.../pinot/spi/config/workload/EnforcementProfile.java 56.25% 6 Missing and 1 partial ⚠️
...pinot/common/utils/config/WorkloadConfigUtils.java 86.36% 3 Missing ⚠️

❗ There is a different number of reports uploaded between BASE (59551e4) and HEAD (517abdd). Click for more details.

HEAD has 11 uploads less than BASE
Flag BASE (59551e4) HEAD (517abdd)
integration2 3 2
temurin 12 11
skip-bytebuffers-false 7 5
unittests 5 3
java-11 5 3
unittests2 3 0
Additional details and impacted files
@@             Coverage Diff              @@
##             master   #15109      +/-   ##
============================================
- Coverage     61.75%   56.16%   -5.59%     
- Complexity      207      777     +570     
============================================
  Files          2436     2175     -261     
  Lines        133233   117001   -16232     
  Branches      20636    18717    -1919     
============================================
- Hits          82274    65714   -16560     
- Misses        44911    45906     +995     
+ Partials       6048     5381     -667     
Flag Coverage Δ
custom-integration1 100.00% <ø> (+99.99%) ⬆️
integration 100.00% <ø> (+99.99%) ⬆️
integration1 100.00% <ø> (+99.99%) ⬆️
integration2 0.00% <ø> (ø)
java-11 56.08% <44.59%> (-5.63%) ⬇️
java-21 56.03% <44.59%> (-5.60%) ⬇️
skip-bytebuffers-false 56.13% <44.59%> (-5.62%) ⬇️
skip-bytebuffers-true 56.00% <44.59%> (+28.27%) ⬆️
temurin 56.16% <44.59%> (-5.59%) ⬇️
unittests 56.16% <44.59%> (-5.59%) ⬇️
unittests1 56.16% <44.59%> (+9.27%) ⬆️
unittests2 ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants