[feature] render new options for rebalance server #15256
Conversation
| export const rebalanceServerOptions: RebalanceServerOption[] = [ | ||
| { | ||
| "name": "dryRun", | ||
| "defaultValue": false, | ||
| "label": "Dry Run", | ||
| "type": "BOOL", | ||
| "description": "If enabled, rebalance will not run but expected changes that will occur will be returned", | ||
| "isAdvancedConfig": false, | ||
| "isStatsGatheringConfig": true, | ||
| "hasBreakingChange": false | ||
| }, | ||
| { | ||
| "name": "preChecks", | ||
| "defaultValue": false, | ||
| "type": "BOOL", | ||
| "label": "Pre-Checks", | ||
| "description": "If enabled, will perform some pre-checks to ensure rebalance is safe, must enable dryRun to enable this", |
There was a problem hiding this comment.
@somandal you can now configure what to show in the UI directly from this config file
There was a problem hiding this comment.
this is great! thank you!
| defaultValue: string | boolean | number; | ||
| isAdvancedConfig: boolean; | ||
| isStatsGatheringConfig: boolean; | ||
| hasBreakingChange: boolean; |
There was a problem hiding this comment.
can we rename this?
perhaps something like: doubleCheckConfigValue, or markWithWarningIcon
There was a problem hiding this comment.
Also, can we show a tool-tip for all the options marked as hasBreakingChange to explain why? I can share the "why" text in the doc we have if this is possible
There was a problem hiding this comment.
Yes, please share what to show in the tooltip
There was a problem hiding this comment.
I've updated the reference doc with some details on the tooltip, please take a look when you get a chance. thanks!
Description
We now have a new set of options both basic and advanced that need to be shown in the UI with
Fix
This PR builds the new UI which modifies the
step 1of selecting options