Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add GridDistance H3 Function #15259

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ashishjayamohan
Copy link
Contributor

  • Addresses: Add useful H3 functions #14703
  • Adds GridDistance function from H3
  • Adds GridDistanceFunctionTest with relevant tests for new GridDistance function

@codecov-commenter
Copy link

codecov-commenter commented Mar 13, 2025

Codecov Report

Attention: Patch coverage is 16.66667% with 25 lines in your changes missing coverage. Please review.

Project coverage is 63.62%. Comparing base (59551e4) to head (5fc972f).
Report is 1837 commits behind head on master.

Files with missing lines Patch % Lines
...atial/transform/function/GridDistanceFunction.java 0.00% 23 Missing ⚠️
.../org/apache/pinot/segment/local/utils/H3Utils.java 50.00% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master   #15259      +/-   ##
============================================
+ Coverage     61.75%   63.62%   +1.87%     
- Complexity      207     1461    +1254     
============================================
  Files          2436     2773     +337     
  Lines        133233   156277   +23044     
  Branches      20636    23983    +3347     
============================================
+ Hits          82274    99439   +17165     
- Misses        44911    49362    +4451     
- Partials       6048     7476    +1428     
Flag Coverage Δ
custom-integration1 100.00% <ø> (+99.99%) ⬆️
integration 100.00% <ø> (+99.99%) ⬆️
integration1 100.00% <ø> (+99.99%) ⬆️
integration2 0.00% <ø> (ø)
java-11 63.59% <16.66%> (+1.88%) ⬆️
java-21 63.52% <16.66%> (+1.89%) ⬆️
skip-bytebuffers-false 63.60% <16.66%> (+1.85%) ⬆️
skip-bytebuffers-true 63.50% <16.66%> (+35.77%) ⬆️
temurin 63.62% <16.66%> (+1.87%) ⬆️
unittests 63.62% <16.66%> (+1.87%) ⬆️
unittests1 56.18% <16.66%> (+9.29%) ⬆️
unittests2 34.16% <6.66%> (+6.43%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@ashishjayamohan
Copy link
Contributor Author

@bziobrowski Mind taking a look at this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants