[SEDONA-505] Fix handling of geometries with SRID=0 in some raster functions #1256
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kontinuation
force-pushed
the
fix-geom-with-0-srid
branch
from
907eaed to
8f8a0b7
Compare
jiayuasu
approved these changes
Feb 28, 2024
jiayuasu
pushed a commit
that referenced
this pull request
Apr 28, 2024
Kontinuation
added a commit
to Kontinuation/sedona
that referenced
this pull request
Oct 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Did you read the Contributor Guide?
Is this PR related to a JIRA ticket?
[SEDONA-XXX] my subject.What changes were proposed in this PR?
The following RS functions do not perform implicit CRS transformation when the geometry has SRID=0:
This behavior is inconsistent with other raster functions such as RS_Value, RS_Intersects, and RS_Clip. We'll change the behavior of listed functions to treat geometries with SRID=0 as if they were in EPSG:4326 and perform implicit CRS transformation if needed.
How was this patch tested?
Updated existing tests and added additional tests
Did this PR include necessary documentation updates?