-
Notifications
You must be signed in to change notification settings - Fork 697
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SEDONA-713] add OSM PBF reader #1823
Conversation
091a0e7
to
4530942
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is the code put in spark-3.5
folder? instead of common
? Does it only work with spark-3.5
?
Hi, I added an example to discuss the correctness of the code. We need to either copy the code for spark 3.4 and 3.3 or abstract the
As I think it might fail for spark 3.4 and 3.3 due to this, I need to confirm it |
@zhangfengcdt @Kontinuation I think we probably ran into this |
I think 3.3 and >3.4.0 should be good bacause the changes are: https://javadoc.io/static/org.apache.spark/spark-sql_2.12/3.3.2/org/apache/spark/sql/execution/datasources/PartitionedFile.html The filePath.toString() shild all return the current URI string. |
Add documentation. Add documentation. Add documentation. Add documentation. Add documentation. SEDONA-713 moving to common.
d9c0d99
to
ef1cbba
Compare
@@ -0,0 +1,167 @@ | |||
/* | |||
* Licensed to the Apache Software Foundation (ASF) under one | |||
* or more contributor license agreements. See the NOTICE file |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If the same OSM reader code works for all versions (i.e., in spark/common
), we should move the test to spark/common
as well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah let's what happens :D
@jiayuasu looks like everything passed |
Did you read the Contributor Guide?
Is this PR related to a JIRA ticket?
Yes, the URL of the associated JIRA ticket is https://issues.apache.org/jira/browse/SEDONA-713. The PR name follows the format
[SEDONA-713] my subject
.No:
[DOCS] my subject
[CI] my subject
What changes were proposed in this PR?
How was this patch tested?
Did this PR include necessary documentation updates?
vX.Y.Z
format.