Fix the SQL join query partition error when deal with too small testdata #207
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jiayuasu
added a commit
that referenced
this pull request
Mar 31, 2018
Fix the SQL join query partition error when deal with too small testdata
jiayuasu
added a commit
that referenced
this pull request
Mar 31, 2018
Fix the SQL join query partition error when deal with too small testdata
jiayuasu
pushed a commit
that referenced
this pull request
Jun 7, 2024
* feat: add implementation * feat: port to flink and spark * feat: add another declaration to spark DataframeAPI
jiayuasu
added a commit
that referenced
this pull request
Jun 7, 2024
* [TASK-92] Add ST_AddMeasure (#207) * feat: add implementation * feat: port to flink and spark * feat: add another declaration to spark DataframeAPI * Update versions --------- Co-authored-by: Furqaan Khan <[email protected]>
Kontinuation
pushed a commit
to Kontinuation/sedona
that referenced
this pull request
Oct 11, 2024
* feat: add implementation * feat: port to flink and spark * feat: add another declaration to spark DataframeAPI
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixed Issue #193.
Bug description: The original code cannot well handle too small test data for spatial join query. When the user provides some super small test data, (2 or 3 rows per DataFrame), the partition number logic will jump in a wrong fallback setting and eventually pick "-1" as the partition number.
Solution: use a smarter Partition Number Optimizer to select a proper partition number for both input tables of a spatial join query.