[SEDONA-260] Don't swap the left and right relations of spatial joins #795
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kontinuation
changed the title
Kontinuation
changed the title
|
This PR changes the behavior of Sedona Conf. We'd better put it in the upcoming Sedona 1.4.0, a major version that allows behavior change. |
…om the right-side relation when running broadcast join.
…rse the spatial predicate instead. Allow distance expression in distance join to reference attributes from the right-side relation when running broadcast join.
Kontinuation
force-pushed
the
sql-join-left-right
branch
from
1fe8819 to
892039a
Compare
Kontinuation
changed the title
jiayuasu
approved these changes
Mar 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Notice
This patch depends on #796.
Did you read the Contributor Guide?
Is this PR related to a JIRA ticket?
[SEDONA-XXX] my subject.What changes were proposed in this PR?
Do not automatically swap the left and right relations when doing spatial joins, since it may cause confusion when the user wants to configure the partition and index-build side of the join.
How was this patch tested?
Tested using existing tests in SpatialJoinSuite.
Did this PR include necessary documentation updates?