3-journal/ files not ending in ".journal" extension are added to yearly include files

[lestephane]

Describe the bug
I cheat a bit and add, next to each .journal file in 3-journal, a .png of a related invoice, and a .json of the google text detection api response. These extra files used to be ignored by hledger-flow import, now they get added to the yearly include, causing hledger to fail:

  |
6 | !include 3-journal/2019/2019-05-31-000.png
  |                                           ^
SourcePos {sourceName = "SCRUBBED/Finance/import/personal/wallet/cash/2019-include.journal", sourceLine = Pos 6, sourceColumn = Pos 43} reading SCRUBBED/Finance/import/personal/wallet/cash/3-journal/2019/2019-05-31-000.png:
SCRUBBED/Finance/import/personal/wallet/cash/3-journal/2019/2019-05-31-000.png: hGetContents: invalid argument (invalid byte sequence)

Version and Runtime Information

hledger-flow-v0.14.2.0

Is this the latest version? yes
Please confirm your issue using the latest version of hledger-flow, maybe it has already been fixed.

Also include the runtime options of the command you ran, e.g:

The enable-future-rundir option is now the default, no need to specify it. This option is currently being ignored and will be removed in future.
RuntimeOptions {baseDir = "SCRUBBED/Finance/", importRunDir = "import/personal/wallet/cash/", importStartYear = Nothing, onlyNewFiles = False, hfVersion = "hledger-flow 0.14.2.0 linux x86_64 ghc 8.10", hledgerInfo = HledgerInfo {hlPath = FilePath "SCRUBBED/Finance/hledger", hlVersion = "hledger 1.20.2"}, sysInfo = SystemInfo {os = "linux", arch = "x86_64", compilerName = "ghc", compilerVersion = Version {versionBranch = [8,10], versionTags = []}}, verbose = False, showOptions = True, sequential = False}
Collecting input files from SCRUBBED/Finance/import/personal/wallet/cash/
Found 100 input files in 0.024561536s. Proceeding with import...

To Reproduce

Add files in 3-journal as part of a construct script

Expected behavior

One of:

• ignore non- .journal extensions in 3-journal
• make the list of extensions that will be included in the yearly include configurable...

[lestephane]

The workaround is to remove all include lines that do not contain .journal from include files:

sed -i -e 's/^!include.*\.\(png\|json\)$/#\0/g' [0-9][0-9][0-9][0-9]-include.journal

[apauley]

I haven't even considered putting other files in the journal dir, but I guess there's no reason this shouldn't be possible 😃

I'll have a look at it within the next 2 or 3 days, hopefully it is an easy fix.

[lestephane]

I have a workaround, so it's not really urgent, but I wanted to let you know that there are creative uses of your tool.

…

On Tue, Feb 2, 2021 at 11:42 AM Andreas Pauley ***@***.***> wrote: I haven't even considered putting other files in the journal dir, but I guess there's no reason this shouldn't be possible 😃 I'll have a look at it within the next 2 or 3 days, hopefully it is an easy fix. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#92 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABJVHFHP4CVFEZ3JHKZNJVTS47CI3ANCNFSM4W4RIZ7Q> .

--

[apauley]

Released as version 0.14.3

[lestephane]

Thanks, I will try it at the end of the month when I do the next round of bookkeeping.

[lestephane]

Verified! Thanks