Replace system-filepath with path #87
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
hledger-flow started as a collection of bash scripts that I translated into Haskell with the help of Turtle.
Turtle uses the now deprecated system-filepath to represent all paths.
I've had many filepath-related issues in hledger-flow.
They were related to issues such as that 2 instances of the same directory would not be treated as equal, because one could have a trailing slash and the other not.
Another issue that popped up was knowing wether a path is a file or a directory, and if it is absolute or relative.
All of these issues are articulated in the
pathlibrary:https://github.com/commercialhaskell/path
This PR switches some usages of
system-filepathover to path