Allow DeepOmit to support partial (#12392)

apollographql · Mar 5, 2025 · 644bb26 · 644bb26
1 parent 6fcad3b
commit 644bb26
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 1 deletion.
diff --git a/.changeset/grumpy-donuts-smoke.md b/.changeset/grumpy-donuts-smoke.md
@@ -0,0 +1,5 @@
+---
+"@apollo/client": patch
+---
+
+Fixes an issue where the DeepOmit type would turn optional properties into required properties. This should only affect you if you were using the omitDeep or stripTypename utilities exported by Apollo Client.
diff --git a/src/utilities/types/DeepOmit.ts b/src/utilities/types/DeepOmit.ts
@@ -22,7 +22,7 @@ export type DeepOmitArray<T extends any[], K> = {
 export type DeepOmit<T, K> =
   T extends DeepOmitPrimitive ? T
   : {
-      [P in Exclude<keyof T, K>]: T[P] extends infer TP ?
+      [P in keyof T as P extends K ? never : P]: T[P] extends infer TP ?
         TP extends DeepOmitPrimitive ? TP
         : TP extends any[] ? DeepOmitArray<TP, K>
         : DeepOmit<TP, K>