Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use published version of the Java support libs #5991

Merged
merged 7 commits into from
Jun 25, 2024
Merged

Use published version of the Java support libs #5991

merged 7 commits into from
Jun 25, 2024

Conversation

BoD
Copy link
Contributor

@BoD BoD commented Jun 24, 2024

No description provided.

@BoD BoD requested a review from martinbonnin as a code owner June 24, 2024 14:04
Copy link

netlify bot commented Jun 24, 2024

Deploy Preview for apollo-android-docs canceled.

Name Link
🔨 Latest commit f811ba2
🔍 Latest deploy log https://app.netlify.com/sites/apollo-android-docs/deploys/6679a917b6245a000889c95d

Comment on lines 8 to 12
import com.apollographql.apollo3.runtime.java.ApolloCallback;
import com.apollographql.apollo3.runtime.java.ApolloClient;
import com.apollographql.apollo3.runtime.java.ApolloDisposable;
import com.apollographql.apollo3.runtime.java.network.ws.protocol.ApolloWsProtocol;
import com.apollographql.apollo3.rx3.java.Rx3Apollo;
import com.apollographql.java.client.ApolloCallback;
import com.apollographql.java.client.ApolloClient;
import com.apollographql.java.client.ApolloDisposable;
import com.apollographql.java.client.network.ws.protocol.ApolloWsProtocol;
import com.apollographql.java.rx3.Rx3Apollo;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Move to apollo-kotlin-java-support?

Comment on lines -1 to -2
#!/usr/bin/env kotlin
import java.io.File
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹

@BoD BoD merged commit 1ad2c62 into main Jun 25, 2024
9 checks passed
@BoD BoD deleted the move-java-support branch June 25, 2024 07:27
BoD added a commit to BoD/apollo-kotlin that referenced this pull request Jul 1, 2024
* Use published version of the Java support libs

* Deprecate Java support modules

* Generate Java/Guava Optional adapters instead of expecting them from the Java client dependency

* Remove integration tests that were moved to the java-support repo

* Update libraries/apollo-api-java/README.md

Co-authored-by: Martin Bonnin <[email protected]>

* Fix artifact id in readmes

* Fix artifact id in code

---------

Co-authored-by: Martin Bonnin <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants