-
Notifications
You must be signed in to change notification settings - Fork 666
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use published version of the Java support libs #5991
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for apollo-android-docs canceled.
|
Comment on lines
8
to
12
import com.apollographql.apollo3.runtime.java.ApolloCallback; | ||
import com.apollographql.apollo3.runtime.java.ApolloClient; | ||
import com.apollographql.apollo3.runtime.java.ApolloDisposable; | ||
import com.apollographql.apollo3.runtime.java.network.ws.protocol.ApolloWsProtocol; | ||
import com.apollographql.apollo3.rx3.java.Rx3Apollo; | ||
import com.apollographql.java.client.ApolloCallback; | ||
import com.apollographql.java.client.ApolloClient; | ||
import com.apollographql.java.client.ApolloDisposable; | ||
import com.apollographql.java.client.network.ws.protocol.ApolloWsProtocol; | ||
import com.apollographql.java.rx3.Rx3Apollo; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Move to apollo-kotlin-java-support
?
Comment on lines
-1
to
-2
#!/usr/bin/env kotlin | ||
import java.io.File |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🧹
Co-authored-by: Martin Bonnin <[email protected]>
martinbonnin
approved these changes
Jun 24, 2024
BoD
added a commit
to BoD/apollo-kotlin
that referenced
this pull request
Jul 1, 2024
* Use published version of the Java support libs * Deprecate Java support modules * Generate Java/Guava Optional adapters instead of expecting them from the Java client dependency * Remove integration tests that were moved to the java-support repo * Update libraries/apollo-api-java/README.md Co-authored-by: Martin Bonnin <[email protected]> * Fix artifact id in readmes * Fix artifact id in code --------- Co-authored-by: Martin Bonnin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.