Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[gradle-plugin] expose the outgoing variants #6329

Merged
merged 3 commits into from
Dec 17, 2024
Merged

Conversation

martinbonnin
Copy link
Contributor

Instead of trying to guess what SoftwareComponent to add the metadata to, just expose them to the user so they can decide what to do with them:

  service("service") {
    generateApolloMetadata.set(true)
    outgoingVariantsConnection {
      addToSoftwareComponent("java")
    }
  }

Note that Android requires afterEvaluate {}:

  service("service") {
    generateApolloMetadata.set(true)
    outgoingVariantsConnection {
      afterEvaluate {
        addToSoftwareComponent("release")
      }
    }
  }

@martinbonnin martinbonnin requested a review from BoD as a code owner December 17, 2024 14:00
@svc-apollo-docs
Copy link
Collaborator

svc-apollo-docs commented Dec 17, 2024

✅ Docs Preview Ready

No new or changed pages found.

Copy link
Contributor

@BoD BoD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚙️

@martinbonnin martinbonnin merged commit db6272e into main Dec 17, 2024
6 checks passed
@martinbonnin martinbonnin deleted the agp-publishing branch December 17, 2024 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants