-
Notifications
You must be signed in to change notification settings - Fork 111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New Feature: Correlation ID support #120
Comments
Hmm, both of these sound useful! How about the CorrelationId as a first-class property (typed as |
Hey @ardalis, I have a new branch with this change that includes a new property typed as a |
Hey Scott, that's great! The usual approach with open source projects is for you to fork the repo to your own, make a new branch, put your cool new bits in there, and then pull request to this repo from your fork. Can you do that? |
Added CorrelationId property, ErrorWithCorrelationId() factory method and unit test
Got it, this is my first time modifying someone else's code so I appreciate the guidance. I forked and created a pull request. Please let me know if anything else is required. |
I have a project where I need to return a correlation ID in an HTTP response, and the correlation ID is currently being generated where I end up returning Result.Error(). Would you be open to me adding a CorrelationId property? Alternatively, I'd also be open to a generic Property Bag using a Dictionary<string, object>. Thoughts?
The text was updated successfully, but these errors were encountered: