Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated github actions to remove deprecation warnings #130

Merged
merged 1 commit into from
Apr 20, 2023

Conversation

thomas-mullaly
Copy link
Contributor

I noticed that there are deprecation warnings with some of the action workflows. Additionally, the action that's being used to publish the nuget packages is no longer maintained. This is a problem because that action uses the set-output command, which GitHub has deprecated and will be completely removing at the end of May.

These upgrades should clear warnings around a deprecated nodejs version and issuse with using set-output.

For the nuget package publishing, I haven't really been able to test the push command but I did try to replicate what the old action was doing to publish packages.

@github-actions
Copy link

Code Coverage

Package Line Rate Branch Rate Complexity Health
Ardalis.Result.SampleWeb 62% 50% 33
Ardalis.Result 32% 18% 64
Ardalis.Result.AspNetCore 65% 70% 126
Ardalis.Result.Sample.Core 25% 33% 50
Ardalis.Result.FluentValidation 0% 0% 6
Summary 47% (357 / 766) 56% (82 / 146) 279

@ardalis
Copy link
Owner

ardalis commented Apr 20, 2023

Thanks!

@ardalis ardalis merged commit 69476fb into ardalis:main Apr 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants