Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add windows .msi installer to the CI #1899

Merged
merged 18 commits into from
Oct 17, 2022

Conversation

umbynos
Copy link
Contributor

@umbynos umbynos commented Sep 30, 2022

Please check if the PR fulfills these requirements

  • The PR has no duplicates (please search among the Pull Requests
    before creating one)
  • The PR follows
    our contributing guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • UPGRADING.md has been updated with a migration guide (for breaking changes)
  • What kind of change does this PR introduce?

build msi installer for windows

  • What is the current behavior?

should solve #705

  • What is the new behavior?

we are able to build an msi installer for windows

nop

  • Other information:

I already added the required secrets to the repo.

The installer is able to install the Arduino CLI to a specified path (by default in C:\Program Files\Arduino CLI) also being able to put that as PATH env variable. Upgrades between versions are working, and the installer should recognize the path of the previous installation, when upgrading.


See how to contribute

@umbynos umbynos added type: enhancement Proposed improvement os: windows Specific to Windows operating system topic: packaging Related to the release distribution package labels Sep 30, 2022
@umbynos umbynos self-assigned this Sep 30, 2022
@umbynos umbynos force-pushed the umbynos/msi-installer branch from fef100d to 1530dc5 Compare September 30, 2022 14:56
@umbynos
Copy link
Contributor Author

umbynos commented Sep 30, 2022

Release run here: https://github.com/umbynos/arduino-cli/actions/runs/3196435180
Test release here: https://github.com/umbynos/arduino-cli/releases/tag/0.0.0-test
Nightly run here: https://github.com/umbynos/arduino-cli/actions/runs/3196554571

The markdown check is expected to fail because I added the new links but did not create yet an official release

@umbynos umbynos force-pushed the umbynos/msi-installer branch from 1530dc5 to 2ac4c14 Compare September 30, 2022 15:18
@umbynos umbynos force-pushed the umbynos/msi-installer branch from 2ac4c14 to a9f58b0 Compare October 5, 2022 17:09
@codecov
Copy link

codecov bot commented Oct 5, 2022

Codecov Report

Base: 36.84% // Head: 36.75% // Decreases project coverage by -0.09% ⚠️

Coverage data is based on head (a8cdfdb) compared to base (fb9d4a8).
Patch has no changes to coverable lines.

❗ Current head a8cdfdb differs from pull request most recent head 09c64e6. Consider uploading reports for the commit 09c64e6 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1899      +/-   ##
==========================================
- Coverage   36.84%   36.75%   -0.10%     
==========================================
  Files         235      231       -4     
  Lines       19763    19684      -79     
==========================================
- Hits         7282     7234      -48     
+ Misses      11650    11624      -26     
+ Partials      831      826       -5     
Flag Coverage Δ
unit 36.75% <ø> (-0.10%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
internal/integrationtest/arduino-cli.go 85.66% <0.00%> (-0.26%) ⬇️
internal/integrationtest/environment.go
internal/integrationtest/http_server.go
internal/integrationtest/shared_directory.go
internal/integrationtest/subtests.go
commands/instances.go 39.79% <0.00%> (+0.15%) ⬆️
arduino/cores/packagemanager/package_manager.go 66.58% <0.00%> (+0.75%) ⬆️
arduino/monitor/monitor.go 47.36% <0.00%> (+6.31%) ⬆️
arduino/resources/index.go 52.57% <0.00%> (+12.37%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@umbynos umbynos force-pushed the umbynos/msi-installer branch 3 times, most recently from 0da4629 to a8cdfdb Compare October 6, 2022 10:28
@umbynos umbynos requested a review from per1234 October 6, 2022 13:50
umbynos and others added 9 commits October 17, 2022 15:13
`warning : Solution properties are only available during IDE builds or when building the solution file from the command line. To turn off this warning set <DefineSolutionProperties>false</DefineSolutionProperties> in your .wixproj`
`error CNDL0108: The Product/@Version attribute's value, '0.0.0-test', is not a valid version.  Legal version values should look like 'x.x.x.x' where x is an integer from 0 to 65534.`
Copy link
Contributor

@per1234 per1234 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent work. Thanks Umberto!

@umbynos umbynos force-pushed the umbynos/msi-installer branch from b71826b to 09c64e6 Compare October 17, 2022 16:01
@umbynos
Copy link
Contributor Author

umbynos commented Oct 17, 2022

Rebased because of #1922

@umbynos umbynos merged commit ea43a9c into arduino:master Oct 17, 2022
@umbynos umbynos deleted the umbynos/msi-installer branch October 17, 2022 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
os: windows Specific to Windows operating system topic: packaging Related to the release distribution package type: enhancement Proposed improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants