-
-
Notifications
You must be signed in to change notification settings - Fork 394
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add windows .msi
installer to the CI
#1899
Conversation
fef100d
to
1530dc5
Compare
Release run here: https://github.com/umbynos/arduino-cli/actions/runs/3196435180 The markdown check is expected to fail because I added the new links but did not create yet an official release |
1530dc5
to
2ac4c14
Compare
2ac4c14
to
a9f58b0
Compare
Codecov ReportBase: 36.84% // Head: 36.75% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #1899 +/- ##
==========================================
- Coverage 36.84% 36.75% -0.10%
==========================================
Files 235 231 -4
Lines 19763 19684 -79
==========================================
- Hits 7282 7234 -48
+ Misses 11650 11624 -26
+ Partials 831 826 -5
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
0da4629
to
a8cdfdb
Compare
`warning : Solution properties are only available during IDE builds or when building the solution file from the command line. To turn off this warning set <DefineSolutionProperties>false</DefineSolutionProperties> in your .wixproj`
`error CNDL0108: The Product/@Version attribute's value, '0.0.0-test', is not a valid version. Legal version values should look like 'x.x.x.x' where x is an integer from 0 to 65534.`
…oes not support xml out of the box
specify timestamp algorithm. Apparently this is required in the latest version of the sdk
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Excellent work. Thanks Umberto!
Co-authored-by: per1234 <[email protected]>
b71826b
to
09c64e6
Compare
Rebased because of #1922 |
Please check if the PR fulfills these requirements
before creating one)
our contributing guidelines
UPGRADING.md
has been updated with a migration guide (for breaking changes)build msi installer for windows
should solve #705
we are able to build an msi installer for windows
titled accordingly?
nop
I already added the required secrets to the repo.
The installer is able to install the Arduino CLI to a specified path (by default in
C:\Program Files\Arduino CLI
) also being able to put that as PATH env variable. Upgrades between versions are working, and the installer should recognize the path of the previous installation, when upgrading.See how to contribute