Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow locale key to be used in config ... commands. #1952

Merged
merged 4 commits into from
Oct 28, 2022
Merged

Allow locale key to be used in config ... commands. #1952

merged 4 commits into from
Oct 28, 2022

Conversation

cmaglie
Copy link
Member

@cmaglie cmaglie commented Oct 26, 2022

Please check if the PR fulfills these requirements

See how to contribute

  • The PR has no duplicates (please search among the Pull Requests
    before creating one)
  • The PR follows
    our contributing guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • UPGRADING.md has been updated with a migration guide (for breaking changes)

What kind of change does this PR introduce?

Allows locale key to be used in config.

What is the current behavior?

$ arduino-cli config set locale de
Settings key doesn't exist
$

What is the new behavior?

The setting is correctly applied:

$ arduino-cli config set locale de
$

Does this PR introduce a breaking change, and is titled accordingly?

No

Other information

Fix #1928

@cmaglie cmaglie self-assigned this Oct 26, 2022
@cmaglie cmaglie requested review from umbynos and per1234 October 26, 2022 15:36
@per1234 per1234 added topic: code Related to content of the project itself type: imperfection Perceived defect in any part of project labels Oct 26, 2022
per1234
per1234 requested changes Oct 26, 2022
View reviewed changes
@umbynos umbynos added this to the Arduino CLI 1.0 milestone Oct 27, 2022
umbynos
umbynos approved these changes Oct 27, 2022
View reviewed changes
Copy link
Contributor

@umbynos umbynos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM 💅

@cmaglie cmaglie requested a review from per1234 October 27, 2022 21:34
per1234
per1234 requested changes Oct 28, 2022
View reviewed changes
per1234
per1234 approved these changes Oct 28, 2022
View reviewed changes
Copy link
Contributor

@per1234 per1234 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Cristian!

@cmaglie cmaglie merged commit 5a4ffe0 into arduino:master Oct 28, 2022
@cmaglie cmaglie deleted the fix_locale branch October 28, 2022 07:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@per1234 per1234 per1234 approved these changes

@umbynos umbynos umbynos approved these changes

Assignees

@cmaglie cmaglie

Labels
topic: code Related to content of the project itself type: imperfection Perceived defect in any part of project
Projects
None yet
Milestone
Arduino CLI v1.0.0
Development

Successfully merging this pull request may close these issues.

[doc] locale is missing from the CLI config spec
3 participants
@cmaglie @per1234 @umbynos