Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lib search returns exact match as the first result. #1975

Merged
merged 3 commits into from
Nov 15, 2022

Conversation

cmaglie
Copy link
Member

@cmaglie cmaglie commented Nov 14, 2022

Please check if the PR fulfills these requirements

See how to contribute

  • The PR has no duplicates (please search among the Pull Requests
    before creating one)
  • The PR follows
    our contributing guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • UPGRADING.md has been updated with a migration guide (for breaking changes)

What kind of change does this PR introduce?

When searching for libraries put the exact match as the first result.

What is the current behavior?

$ arduino-cli lib search FlashStorage --names
Sto scaricando l'indice: library_index.tar.bz2 downloaded                                                                                                                                                   
Nome: "BlynkEthernet_Manager"
Nome: "Blynk_Esp8266AT_WM"
Nome: "Blynk_WiFiNINA_WM"
Nome: "DoubleResetDetector_Generic"
Nome: "DueFlashStorage"
Nome: "ESP_AT_WM_Lite"
Nome: "ESP_AT_WiFiManager"
Nome: "Ethernet_Manager"
Nome: "Ethernet_Manager_STM32"
Nome: "FlashStorage"
Nome: "FlashStorage_RTL8720"
Nome: "FlashStorage_SAMD"
Nome: "FlashStorage_STM32"
Nome: "FlashStorage_STM32F1"
Nome: "KonnektingFlashStorage"
Nome: "MultiResetDetector_Generic"
Nome: "WiFiManager_Generic_Lite"
Nome: "WiFiManager_NINA_Lite"
Nome: "WiFiManager_RTL8720"

What is the new behavior?

$ arduino-cli lib search FlashStorage --names
Sto scaricando l'indice: library_index.tar.bz2 downloaded                                                                                                                                                   
Nome: "FlashStorage"
Nome: "BlynkEthernet_Manager"
Nome: "Blynk_Esp8266AT_WM"
Nome: "Blynk_WiFiNINA_WM"
Nome: "DoubleResetDetector_Generic"
Nome: "DueFlashStorage"
Nome: "ESP_AT_WM_Lite"
Nome: "ESP_AT_WiFiManager"
Nome: "Ethernet_Manager"
Nome: "Ethernet_Manager_STM32"
Nome: "FlashStorage_RTL8720"
Nome: "FlashStorage_SAMD"
Nome: "FlashStorage_STM32"
Nome: "FlashStorage_STM32F1"
Nome: "KonnektingFlashStorage"
Nome: "MultiResetDetector_Generic"
Nome: "WiFiManager_Generic_Lite"
Nome: "WiFiManager_NINA_Lite"
Nome: "WiFiManager_RTL8720"

Does this PR introduce a breaking change, and is titled accordingly?

No

Other information

Fix #1974

@cmaglie cmaglie added type: enhancement Proposed improvement priority: low Resolution is a low priority topic: code Related to content of the project itself criticality: medium Of moderate impact labels Nov 14, 2022
@cmaglie cmaglie added this to the Arduino CLI 1.0 milestone Nov 14, 2022
@cmaglie cmaglie requested a review from umbynos November 14, 2022 22:22
@cmaglie cmaglie self-assigned this Nov 14, 2022
@cmaglie cmaglie merged commit 0b2c38d into arduino:master Nov 15, 2022
@cmaglie cmaglie deleted the search_boost_exact_match branch November 15, 2022 09:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
criticality: medium Of moderate impact priority: low Resolution is a low priority topic: code Related to content of the project itself type: enhancement Proposed improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Boost libraries with the exact match
3 participants