fix: consistent boards list ordering #2025
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bikappa
commented
Jan 4, 2023
Codecov ReportBase: 36.53% // Head: 36.51% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #2025 +/- ##
==========================================
- Coverage 36.53% 36.51% -0.03%
==========================================
Files 228 228
Lines 19294 19316 +22
==========================================
+ Hits 7050 7053 +3
- Misses 11413 11433 +20
+ Partials 831 830 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Bikappa
force-pushed
the
fix/consistent-boards-list-order
branch
from
d3c3ef6 to
81d6fd8
Compare
cmaglie
approved these changes
Jan 4, 2023
per1234
added
topic: code
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
See how to contribute
before creating one)
our contributing guidelines
UPGRADING.mdhas been updated with a migration guide (for breaking changes)What kind of change does this PR introduce?
Makes the
board listallcommand output order consistent across formats. The list items are ordered by the package and platforms names they belong too, other than the board names themselves.The plain text format remains an exception to this as it's sorted alphabetically by board name.
What is the current behavior?
In output formats other than plain text the board list is inconsistently ordered: while the boards within a single package/platform are ordered alphabetically they might appear before or after the ones of an other package/platform.
What is the new behavior?
The list is ordered by package, platform and board names.
Does this PR introduce a breaking change, and is titled accordingly?
No
Other information
Fixes #1909, although ordering between plain text and other formats remains different