Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade golang version to 1.24 #2850

Draft
wants to merge 4 commits into
base: master
Choose a base branch
from
Draft

Conversation

cmaglie
Copy link
Member

@cmaglie cmaglie commented Feb 27, 2025

Please check if the PR fulfills these requirements

See how to contribute

  • The PR has no duplicates (please search among the Pull Requests
    before creating one)
  • The PR follows
    our contributing guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • UPGRADING.md has been updated with a migration guide (for breaking changes)
  • configuration.schema.json updated if new parameters are added.

What kind of change does this PR introduce?

As per subject.

What is the current behavior?

What is the new behavior?

Does this PR introduce a breaking change, and is titled accordingly?

Other information

@cmaglie cmaglie added type: enhancement Proposed improvement topic: infrastructure Related to project infrastructure labels Feb 27, 2025
@cmaglie cmaglie self-assigned this Feb 27, 2025
@cmaglie
Copy link
Member Author

cmaglie commented Feb 27, 2025

Could not upgrade due to this:

2025-02-27T10:35:36.7331257Z Installing platform opentracker:[email protected]...
2025-02-27T10:35:36.7334083Z Error during install: Cannot install platform: installing platform opentracker:[email protected]: extracting archive: Create file C:\Users\runneradmin\AppData\Local\Temp\cli2305421146\A\tmp\package-162356431\1.0.5\system\libsam\build_gcc\NUL: open C:\Users\runneradmin\AppData\Local\Temp\cli2305421146\A\tmp\package-162356431\1.0.5\system\libsam\build_gcc\NUL: Incorrect function.
2025-02-27T10:35:36.7336277Z �[90m<<< Run completed (err = exit status 1)�[0m
2025-02-27T10:35:36.7336881Z ##[endgroup]
2025-02-27T10:35:36.7337272Z     core_test.go:1367: 
2025-02-27T10:35:36.7338737Z         	Error Trace:	D:/a/arduino-cli/arduino-cli/internal/integrationtest/core/core_test.go:1367
2025-02-27T10:35:36.7339517Z         	Error:      	Received unexpected error:
2025-02-27T10:35:36.7340073Z         	            	exit status 1
2025-02-27T10:35:36.7340628Z         	Test:       	TestCoreInstallWithWrongArchiveSize
2025-02-27T10:35:38.3263830Z --- FAIL: TestCoreInstallWithWrongArchiveSize (10.14s)

There is a regression in golang 1.24.0: golang/go#71752, we need to wait for go1.24.1.

@cmaglie cmaglie marked this pull request as draft February 27, 2025 10:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: infrastructure Related to project infrastructure type: enhancement Proposed improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant