Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: documentation notifications configuration example #1610

Merged

Conversation

Vikaspogu
Copy link
Contributor

Subscription supposed to lowercase and no pipe is need at the end

What type of PR is this?

What does this PR do / why we need it:
Notification configuration examples for subscriptions use uppercase letter and do not need to include a "|" at the end, which causes issues.

Have you updated the necessary documentation?

  • Documentation update is required by this PR.
  • Documentation has been updated.

Which issue(s) this PR fixes:

Fixes #?

How to test changes / Special notes to the reviewer:

Subscription supposed to lowercase and no pipe is need at the end

Signed-off-by: Vikas Pogu <[email protected]>
@Vikaspogu Vikaspogu force-pushed the notificationsconfiguration-doc-fix branch from 3d1c6cc to 67dcf35 Compare November 27, 2024 12:40
Copy link
Collaborator

@svghadi svghadi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks alot @Vikaspogu for the contribution!

@svghadi svghadi changed the title Fix: documentation notifications configuration example docs: documentation notifications configuration example Nov 28, 2024
@svghadi svghadi merged commit 9174e68 into argoproj-labs:master Nov 28, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants