Axon 137 sidebar UI new sidebar view for jq ls #154
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cabella-dot
commented
Feb 28, 2025
cabella-dot
requested review from
bwieger-atlassian-com,
sdzh-atlassian and
marcomura
as code owners
marcomura
reviewed
Feb 28, 2025
marcomura
reviewed
Feb 28, 2025
src/container.ts
Outdated
| this.initializeUriHandler(context, this._analyticsApi, this._bitbucketHelper); | ||
| }); | ||
| }) | ||
| .then(() => { |
There was a problem hiding this comment.
how about removing then(), catch the error and log it, and launch all the initialization in a finally() ?
nothing should be conditional to the success or failure of the feature flag initializer because we have default values in case of failure
There was a problem hiding this comment.
the downside of the current implementation is that there are two different entrypoint for initializeLegacySidebarView and it's harder to follow the logic
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Demo:
https://www.loom.com/share/6cd9a9ec8fd14dbdbe7aa78966ab4b69