-
-
Notifications
You must be signed in to change notification settings - Fork 270
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: belongs_to field should use association primary_key #3665
base: main
Are you sure you want to change the base?
Conversation
Code Climate has analyzed commit e580342 and detected 0 issues on this pull request. View more on Code Climate. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for looking into this, @Nevelito!
I tested this PR using the reproduction repo, and it does seem to resolve the issue. However, the test coverage doesn't currently reproduce the problem. Would it be possible to add a belongs_to
relationship that uses primary_key
in the dummy app and write a test against that scenario?
Description
If record had primary_key set, it was still using :id
Changes:
Fixes # (issue)
Issue: #3413
Checklist:
Screenshots & recording