fix awsjson error deserialization to not expect string code #2489
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
syall
reviewed
Feb 13, 2024
...go-codegen/src/main/java/software/amazon/smithy/aws/go/codegen/JsonRpcProtocolGenerator.java
Show resolved
Hide resolved
syall
suggested changes
Feb 13, 2024
...go-codegen/src/main/java/software/amazon/smithy/aws/go/codegen/JsonRpcProtocolGenerator.java
Show resolved
Hide resolved
...go-codegen/src/main/java/software/amazon/smithy/aws/go/codegen/JsonRpcProtocolGenerator.java
Show resolved
Hide resolved
lucix-aws
force-pushed
the
fix-awsjson-errors
branch
from
ec1af14 to
9608634
Compare
syall
approved these changes
Feb 13, 2024
wty-Bryant
approved these changes
Feb 13, 2024
lucix-aws
force-pushed
the
fix-awsjson-errors
branch
from
38b28cb to
49091ea
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes json-body error code deserialization to not strictly expect any
Codefield to be a string.In practice I've essentially split the jsonrpc protocols away from using the static
aws/protocols/restjson.GetErrorInfo, they have a new implementation which is used instead.The isolation to jsonrpc was to mitigate behavioral impact, it's also not clear to me whether this weird dichotomy between code and __type applies the same for the REST side. We can update it globally if we'd rather do so.
Closes #2476