ci: Emit benchmark metrics from scheduled runs #5064
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
goatgoose
force-pushed
the
fix-scheduled-bench
branch
from
c2380a8 to
620c147
Compare
goatgoose
force-pushed
the
fix-scheduled-bench
branch
from
620c147 to
5b5e944
Compare
CarolYeh910
approved these changes
Jan 28, 2025
jmayclin
approved these changes
Jan 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
#5007 updated the bench github action to build and run the benchmarks on PRs, but not publish any metrics. The condition I used to skip this step in the workflow was
if: github.event_name == 'push'. This did succeed in preventing the metrics from emitting on PRs, but also prevented the metrics from emitting on scheduled runs.This PR updates the metric emit condition to anything but PRs, so it will run on both pushes to main and on scheduled runs.
Call-outs:
None
Testing:
The bench action on this PR skips the emit steps:
https://github.com/aws/s2n-tls/actions/runs/13014897818/job/36301511926?pr=5064
This indicates that it will emit in all other circumstances.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.