-
Notifications
You must be signed in to change notification settings - Fork 722
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test(integv2): add partial support for OpenSSL 3.0 provider #5131
Open
johubertj
wants to merge
15
commits into
aws:main
Choose a base branch
from
johubertj:feature-add-openSSL3
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+48
−16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmayclin
reviewed
Feb 25, 2025
Also, I think there are some tests that aren't passing under openssl 3.0 with this PR? Let's call that out in the PR description. And I'd also vote to edit the CR title to |
jmayclin
reviewed
Feb 27, 2025
Co-authored-by: James Mayclin <[email protected]>
Co-authored-by: James Mayclin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolved issues:
Description of changes:
Problem
This PR removes the constraint that forces the OpenSSL provider executable to be from version 1.1.1, allowing support for modern OSs that use OpenSSL 3.0. The "version supported" method has been updated to accommodate OpenSSL 3.0, which only supports TLS 1.3 and TLS 1.2 by default. Additionally, Certificates.RSA_1024 tests are now skipped for OpenSSL 3.0.
Future Investigation
After adding openSSL 3.0 as a provider, the below test cases are failing and need more investigation
test_serialization.py
test_renegotiate_apache.py
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.