Accept multiple --group-match for OR search. #55
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ptqa
pushed a commit
to simplepractice/ssosync
that referenced
this pull request
Sep 17, 2021
ptqa
pushed a commit
to simplepractice/ssosync
that referenced
this pull request
Sep 17, 2021
|
@ryotarai we've tested this on our infra, seems to be working fine. multiple groups created, users are added to these groups correctly |
dgarbus
added a commit
to dgarbus/ssosync
that referenced
this pull request
May 10, 2022
|
The multiple flag approach is fine for cli use but not suitable for lambda. However the desired functionality is being implemented under the feature branch feature-EnhancedMatch and will be released shortly. |
The branch doesn't implement the functionality yet right? Using |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
Because Search query for Google Groups does not support OR clause, we cannot specify multiple groups especially in
groupssync method.This PR makes
--group-matcha slice flag and it works as OR clause.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.