-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: fix false positive eslint-disable errors raised #484
Open
hugop95
wants to merge
21
commits into
azat-io:main
Choose a base branch
from
hugop95:fix/fallback-sort
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #484 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 94 94
Lines 7620 7618 -2
Branches 1634 1635 +1
=========================================
- Hits 7620 7618 -2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
c0c6854
to
20e6721
Compare
- We only call `computeCompareValue` once at this point, and it doesn't need `fallbackSort`.
20e6721
to
c197d88
Compare
c197d88
to
6d85f70
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fallbackSort
causessort-imports
failed to fix #483 (one of the two bugs of that issue)Description
Some
eslint-disable
errors are raised when they should not in specific situations due to a missing condition.Bug severity
Low:
Code example
This currently raises an unfixable error.
What is the purpose of this pull request?