Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix false positive eslint-disable errors raised #484

Open
wants to merge 21 commits into
base: main
Choose a base branch
from

Conversation

hugop95
Copy link
Contributor

@hugop95 hugop95 commented Mar 9, 2025

Description

Some eslint-disable errors are raised when they should not in specific situations due to a missing condition.

Bug severity

Low:

  • Not related to a new feature.
  • Only happens in specific situations.
  • Can be bypassed by moving elements around in the worst case.

Code example

interface Test {
  b: string;
  c: string;
  // eslint-disable-next-line
  a: string;
}

This currently raises an unfixable error.

What is the purpose of this pull request?

  • Bug fix

Copy link

codecov bot commented Mar 9, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (9da25bd) to head (6eb32fe).

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #484   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           94        94           
  Lines         7620      7618    -2     
  Branches      1634      1635    +1     
=========================================
- Hits          7620      7618    -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@hugop95 hugop95 force-pushed the fix/fallback-sort branch 5 times, most recently from c0c6854 to 20e6721 Compare March 9, 2025 15:55
@hugop95 hugop95 force-pushed the fix/fallback-sort branch from 20e6721 to c197d88 Compare March 9, 2025 20:46
@hugop95 hugop95 force-pushed the fix/fallback-sort branch from c197d88 to 6d85f70 Compare March 10, 2025 14:36
@hugop95 hugop95 marked this pull request as ready for review March 10, 2025 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant