fix(sort-imports): fix explicit fallbackSort
overriding side-effects
#485
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #483
Description
Explicitely writing
fallbackSort
insort-imports
will overridesideEffects
which should stay unsorted.Bug severity
Medium-high:
fallbackSort
option, meaning thattype
should beline-length
logically.=> I think that a hotfix is justified.
What is the purpose of this pull request?