Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(sort-imports): fix explicit fallbackSort overriding side-effects #485

Merged
merged 1 commit into from
Mar 9, 2025

Conversation

hugop95
Copy link
Contributor

@hugop95 hugop95 commented Mar 9, 2025

Fixes #483

Description

Explicitely writing fallbackSort in sort-imports will override sideEffects which should stay unsorted.

Bug severity

Medium-high:

  • Related to a relatively new feature (fallback sorting)
  • Requires writing an explicit fallbackSort option, meaning that type should be line-length logically.
  • Side-effects import order can break runtime.

=> I think that a hotfix is justified.

What is the purpose of this pull request?

  • Bug fix

Copy link

codecov bot commented Mar 9, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (8d4ad4f) to head (59e41ac).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #485   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           94        94           
  Lines         7617      7620    +3     
  Branches      1632      1634    +2     
=========================================
+ Hits          7617      7620    +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@hugop95 hugop95 marked this pull request as ready for review March 9, 2025 15:43
@hugop95
Copy link
Contributor Author

hugop95 commented Mar 9, 2025

Hi @azat-io 👋

For this bug, I believe that deploying a hotfix is appropriate.

@azat-io
Copy link
Owner

azat-io commented Mar 9, 2025

Okay, I'll create release. Thank you!

@azat-io azat-io merged commit 1ac83c9 into azat-io:main Mar 9, 2025
10 checks passed
@hugop95 hugop95 deleted the fix/sort-imports/side-effect branch March 9, 2025 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: fallbackSort causes sort-imports failed to fix
2 participants