Fix iOS 11 text rendering issue #364
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
allowsNonContiguousLayout should only be used for large documents, and, if so, the ensureGlyph(...) functions must be called. Since we don't deal with large documents, we don't need this option. An optimization on iOS 11 made the text not to render on some circumstances (for instance when there is a carriage return).
Codecov Report
@@ Coverage Diff @@
## master #364 +/- ##
==========================================
+ Coverage 63.62% 63.64% +0.01%
==========================================
Files 77 77
Lines 3929 3928 -1
==========================================
Hits 2500 2500
+ Misses 1429 1428 -1
Continue to review full report at Codecov.
|
|
@0xpablo I'll do performance tests on slow devices for both iOS 10 and 11. I have no idea why it was set to true from the beginning, but I believe it was related to rendering performance. @diegosanchezr Do you remember anything about it? |
|
I don't recall anything in particular. It's just probably there with hopes of better performance as it was working fine with it at that time. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It looks like on iOS 11, when a text bubble has a carriage return, it renders blank like this:
It looks like Chatto is setting
allowsNonContiguousLayouttotrueon the text view. This option is for large documents when you only want to render part of it (you can read more about this on the "Noncontiguous Layout" section of NSLayoutManager.It is stated that if you use that option, you are in charge of telling the layout manager to generate the glyphs for a given range.
We have 2 options:
ensureGlyph(...)functions.allowsNonContiguousLayout.I think it makes no sense to use the ensureGlyph option as this is for only generating a given range. Bubbles in general are needed to be fully rendered and determining the range to render a given large bubble is complex and I believe out of the scope of ChattoAdditions. This PR then simply deletes the line that sets
allowsNonContiguousLayouttotrue.