Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed issues with implicit animations in some bubbles #604

Merged
merged 2 commits into from
Sep 3, 2019

Conversation

AntonPalich
Copy link
Contributor

No description provided.

@codecov-io
Copy link

codecov-io commented Sep 3, 2019

Codecov Report

Merging #604 into master will increase coverage by 0.2%.
The diff coverage is 75%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master     #604     +/-   ##
=========================================
+ Coverage   58.86%   59.07%   +0.2%     
=========================================
  Files          91       91             
  Lines        3948     3958     +10     
=========================================
+ Hits         2324     2338     +14     
+ Misses       1624     1620      -4
Impacted Files Coverage Δ
...ems/CompoundMessage/Views/CompoundBubbleView.swift 6.97% <0%> (-0.35%) ⬇️
ChattoAdditions/Source/Common/AnimationUtils.swift 100% <100%> (ø) ⬆️
...at Items/PhotoMessages/Views/PhotoBubbleView.swift 85.91% <100%> (+0.3%) ⬆️
...Chat Items/TextMessages/Views/TextBubbleView.swift 82.79% <0%> (+6.45%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6da4a58...7116656. Read the comment docs.

@wiruzx wiruzx self-requested a review September 3, 2019 09:39
@turbulem turbulem self-requested a review September 3, 2019 10:51
@wiruzx wiruzx merged commit b4555d2 into master Sep 3, 2019
@wiruzx wiruzx deleted the fixed_issue_with_implicit_animations branch September 3, 2019 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants