Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use bounds height change in adjustCollectionViewInsets #623

Merged
merged 2 commits into from
Nov 5, 2019

Conversation

leonspok
Copy link
Contributor

@leonspok leonspok commented Nov 5, 2019

This change is needed only for the case when placeMessagesFromBottom = true.

Before fix:

before 2019-11-05 11_03_55

After fix:

after 2019-11-05 11_03_23

@codecov-io
Copy link

codecov-io commented Nov 5, 2019

Codecov Report

Merging #623 into master will decrease coverage by 11.65%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master     #623       +/-   ##
===========================================
- Coverage   72.51%   60.85%   -11.66%     
===========================================
  Files          19       92       +73     
  Lines        1215     4892     +3677     
===========================================
+ Hits          881     2977     +2096     
- Misses        334     1915     +1581
Impacted Files Coverage Δ
...Source/ChatController/BaseChatViewController.swift 70.33% <100%> (+1.12%) ⬆️
...otos/PhotosInputWithPlaceholdersDataProvider.swift 80.76% <0%> (ø)
ChattoAdditions/Source/Input/TabInputButton.swift 94.11% <0%> (ø)
...s/CircleProgressIndicatorView/CircleIconView.swift 68.04% <0%> (ø)
...s/PhotoMessageCollectionViewCellDefaultStyle.swift 84.09% <0%> (ø)
.../Chat Items/BaseMessage/BaseMessagePresenter.swift 62.61% <0%> (ø)
ChattoAdditions/Source/Common/Observable.swift 100% <0%> (ø)
...aceholder/PhotosInputPlaceholderDataProvider.swift 33.33% <0%> (ø)
...ditions/Source/Common/UIEdgeInsets+Additions.swift 100% <0%> (ø)
...aceholder/PhotosInputPlaceholderCellProvider.swift 0% <0%> (ø)
... and 64 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dbfacce...bd2bb87. Read the comment docs.

@leonspok leonspok merged commit 6cb0868 into master Nov 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants