Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Determine UI orientation without shared UIApplication object #637

Merged
merged 1 commit into from
Jul 13, 2020

Conversation

FabioTacke
Copy link
Contributor

This resolves #534.
Using UIApplication.shared makes ChattoAdditions unable to be used in App Extensions. I might not be the only one wanting to use this chat library in an iOS App Notification Service Extension for displaying and storing chat messages that arrived via remote notification.

I replaced the orientation determination with a quite popular method that is totally fine if UIApplication.shared is not an option.

@FabioTacke FabioTacke force-pushed the uiOrientationDetermination branch from e2b9cb5 to e16b076 Compare January 27, 2020 08:58
@codecov-io
Copy link

codecov-io commented Jan 27, 2020

Codecov Report

Merging #637 into master will decrease coverage by 0.03%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #637      +/-   ##
==========================================
- Coverage   61.25%   61.22%   -0.04%     
==========================================
  Files          92       93       +1     
  Lines        4969     4972       +3     
==========================================
  Hits         3044     3044              
- Misses       1925     1928       +3
Impacted Files Coverage Δ
...Additions/Source/Input/ChatInputBarPresenter.swift 60.63% <0%> (ø) ⬆️
...oAdditions/Source/Input/InterfaceOrientation.swift 0% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 00144dd...5f6ef7c. Read the comment docs.

@FabioTacke FabioTacke force-pushed the uiOrientationDetermination branch from e16b076 to 30ba0e3 Compare January 27, 2020 09:13
@wiruzx wiruzx self-requested a review February 4, 2020 07:57
@ChaosCoder ChaosCoder force-pushed the uiOrientationDetermination branch from 30ba0e3 to 5f6ef7c Compare February 15, 2020 12:13
@wiruzx wiruzx merged commit c95ce2c into badoo:master Jul 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Chat Additions /UIKit.UIApplication:5:20: 'shared' has been explicitly marked unavailable here
3 participants