Fix masking in iOS 14 #667
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #667 +/- ##
=======================================
Coverage 73.38% 73.38%
=======================================
Files 19 19
Lines 1236 1236
=======================================
Hits 907 907
Misses 329 329 Continue to review full report at Codecov.
|
|
Hey @esilverberg, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PhotoBubbleViewcells no longer render images properly if you attempt to run in the iOS 14 simulator on Xcode 12. This is caused by this issue here:https://developer.apple.com/forums/thread/656554
This has to do with the way that masks are applied to
PhotoBubbleViewcells.I have implemented a fix by creating an extension on
UIImageView. I attempted to follow the existing pattern established by the project. In so doing, I needed to update the Podfile in the sample app to get it to compile. However, this is a short change and the meat of it is in the UIImageView+Additions.swift file.