Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix false positive test runs #680

Merged
merged 1 commit into from
Sep 27, 2020
Merged

Fix false positive test runs #680

merged 1 commit into from
Sep 27, 2020

Conversation

wiruzx
Copy link
Contributor

@wiruzx wiruzx commented Sep 27, 2020

Because we have pipe to xcpretty at the end of the test.sh script, returned exit code is zero even if xcodebuild fails.
We need to enable pipefail option in order to fix that behaviour.
For more information see documentation on set.

@codecov-commenter
Copy link

codecov-commenter commented Sep 27, 2020

Codecov Report

Merging #680 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #680   +/-   ##
=======================================
  Coverage   44.77%   44.77%           
=======================================
  Files          98       98           
  Lines        5119     5119           
=======================================
  Hits         2292     2292           
  Misses       2827     2827           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3f4318f...72fe1f1. Read the comment docs.

@wiruzx wiruzx merged commit eceae0e into master Sep 27, 2020
@wiruzx wiruzx deleted the fix-false-positive-test-runs branch September 27, 2020 06:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants