fix: Load subjects #162
Merged
fix: Load subjects #162
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Type checker doesn't like it, but this fixes it for now. The real fix I think will be to only call the function once, so we can get rid of the `null` check.
|
@rwblair After this is reviewed and merged, we'll need another release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type checker doesn't like it, but this fixes the failure to load from TSV files for now. We don't want to synchronously load TSV files during object construction, but nor do we really want to treat subjects as maybe missing.
The real fix I think will be to only call the function once, so we can get rid of the
nullcheck.